ReproNim / reproman

ReproMan (AKA NICEMAN, AKA ReproNim TRD3)
https://reproman.readthedocs.io
Other
24 stars 14 forks source link

slurm: all jobs must have a queue name specified with "-p" #549

Open yarikoptic opened 3 years ago

yarikoptic commented 3 years ago
(reproman-dev) login2.ls5(33)$ reproman create -t shell local
2020-10-09 14:54:34,583 [INFO   ] Created the environment local 
(reproman-dev) login2.ls5(34)$ reproman run --follow -r local --sub slurm --orc datalad-no-remote python -m nose -s -v datalad
2020-10-09 14:56:16,889 [INFO   ] Submitting 20201009-145615-463e                                                       
2020-10-09 14:56:16,893 [INFO   ] No root directory supplied for local; using '/home1/03372/yoh/.reproman/run-root' 
2020-10-09 14:56:16,932 [INFO   ] Submitting /home1/03372/yoh/testslurm/.reproman/jobs/local/20201009-145615-463e/submit 
2020-10-09 14:56:16,942 [ERROR  ] CommandError: command '['sbatch', '/home1/03372/yoh/testslurm/.reproman/jobs/local/20201009-145615-463e/submit']' failed with exitcode 1
| Failed to run ['sbatch', '/home1/03372/yoh/testslurm/.reproman/jobs/local/20201009-145615-463e/submit'] under None. Exit code=1. out=
| -----------------------------------------------------------------
|           Welcome to the Lonestar 5 Supercomputer          
| -----------------------------------------------------------------
| 
| --> Submission error: all jobs must have a queue name specified with "-p"
| 
|  err= [cmd.py:run:292] (CommandError) 
(reproman-dev) login2.ls5(35)$ sbatch --version

-----------------------------------------------------------------
          Welcome to the Lonestar 5 Supercomputer          
-----------------------------------------------------------------

slurm 18.08.3
(reproman-dev) login2.ls5(36)$ sbatch --help
...
  -p, --partition=partition   partition requested

I wonder what would be the best way to address for such "particularities"? may be we could add a "parameter" submitter_opts to be added to submitter's submit_command?

FTR here is the list I had to provide to get it "going"

(reproman-dev) login2.ls5(53)$ git diff | cat
diff --git a/reproman/support/jobs/submitters.py b/reproman/support/jobs/submitters.py
index d069e1e..056c9f7 100644
--- a/reproman/support/jobs/submitters.py
+++ b/reproman/support/jobs/submitters.py
@@ -281,7 +281,7 @@ class SlurmSubmitter(Submitter):
     @property
     @borrowdoc(Submitter)
     def submit_command(self):
-        return ["sbatch"]
+        return ["sbatch", "-p", "normal", "-n", "1", "-N", "1", "-t", "90"]

     @borrowdoc(Submitter)
     def submit(self, script, submit_command=None):