codecov[bot]
commented
3 years ago Codecov Report
Merging #565 (4ff767c) into master (4322819) will increase coverage by
0.19%. The diff coverage is62.50%.
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 89.41% 89.60% +0.19%
==========================================
Files 149 149
Lines 12656 12954 +298
==========================================
+ Hits 11316 11608 +292
- Misses 1340 1346 +6 | Impacted Files | Coverage Δ | |
|---|---|---|
| reproman/distributions/tests/test_venv.py | 95.68% <62.50%> (-2.39%) |
:arrow_down: |
| reproman/distributions/venv.py | 88.37% <0.00%> (-0.78%) |
:arrow_down: |
| reproman/ui/tests/test_base.py | 23.07% <0.00%> (-0.46%) |
:arrow_down: |
| reproman/tests/fixtures.py | 100.00% <0.00%> (ø) |
|
| reproman/tests/test_api.py | 100.00% <0.00%> (ø) |
|
| reproman/support/digests.py | 100.00% <0.00%> (ø) |
|
| reproman/formats/reprozip.py | 100.00% <0.00%> (ø) |
|
| reproman/tests/test_dochelpers.py | 100.00% <0.00%> (ø) |
|
| reproman/formats/tests/fixtures.py | 100.00% <0.00%> (ø) |
|
| reproman/interface/tests/test_ls.py | 100.00% <0.00%> (ø) |
|
| ... and 56 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4322819...4ff767c. Read the comment docs.
yarikoptic
test_venv_identify_distributions() checks how links inside the virtual environment are handled by identify_distributions(). On Travis, this test has started to fail for the Python 3.8 build. The last passing run for the 3.8 build had Python 3.8.0, while the failure has 3.8.6.
failing: https://travis-ci.org/github/ReproNim/reproman/jobs/753369730 passing: https://travis-ci.org/github/ReproNim/reproman/jobs/745766696
The failing assertion is due to the layout in the environment not meeting two expectations:
We expect the paths of abc.py and machinery.py to be links to the outside.
$ realpath $VENV/lib/python3.7/abc.py /usr/lib/python3.7/abc.py $ realpath $VENV/lib/python3.7/importlib/machinery.py /usr/lib/python3.7/importlib/machinery.py
But when I test with Ubuntu 20.04 (Python 3.8.5), nothing exists in $VENV/lib/python3.8 except for the site-packages directory.
We expect $VENV/bin/python to link elsewhere within the environment.
$ realpath $VENV/bin/python $VENV/bin/python3.7
But with Ubuntu 20.04, it points outside.
$ realpath $VENV/bin/python /usr/bin/python3.8
Deal with the first one by only tracing abc.py and machinery.py when those files exist in the environment. Keep the test for the second case (i.e. a link in the environment that points to another non-package file in the environment) by tracing bin/pip rather bin/python.
I have not identified the upstream change that led to this layout change.