BF: orchestrators: Update for change in 'datalad subdatasets' key

[kyleam]

In DataLad v0.12.0 (c89746c27e), the "revision" key in the results for datalad subdatasets was changed from "revision" to "gitshasum", and the old name was kept around for compatibility. The old key will be removed in the upcoming 0.14 release (f5c3104d88).

Switch to using "gitshasum". (Our minimum DataLad version is 0.13, so a compatibility kludge isn't needed.)

Fixes #568.

[kyleam]

Switch to using "gitshasum". (Our minimum DataLad version is 0.13, so a compatibility kludge isn't needed.)

Hmm, based on the test failure, I'm clearly missing something here.

>           cmds = [["git", "checkout", res["gitshasum"]],
                    ["git", "annex", "init"]]
E           KeyError: 'gitshasum'

reproman/support/jobs/orchestrators.py:754: KeyError

Edit: The "remote" has an older datalad.

https://github.com/ReproNim/reproman/blob/03135e96b9c7e5b55d6da12557cf526bf19e9488/tools/ci/install_datalad#L7-L8

Setting up datalad (0.11.6-1~nd16.04+1) ...

[kyleam]

The "remote" has an older datalad.

In the long run, this points to the need to specify minimum versions of remote programs and to make the orchestrators check them (gh-477). And the fact that Travis is stuck on an older version can be seen as a good or bad thing, though of course ideally there would be builds for both the minimum and latest versions, at least for datalad.

Anyway, for now, I'll rework this patch to look for either key.

[codecov[bot]]

Codecov Report

Merging #569 (f0945d9) into master (6717f81) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #569   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files         149      149           
  Lines       13027    13029    +2     
=======================================
+ Hits        11638    11640    +2     
  Misses       1389     1389           

Impacted Files	Coverage Δ
reproman/support/jobs/orchestrators.py	94.20% <100.00%> (+0.02%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6717f81...f0945d9. Read the comment docs.

[yarikoptic]

thank you @kyleam !