Closed kyleam closed 3 years ago
Merging #576 (d82dbbe) into master (8148fcd) will increase coverage by
0.03%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
+ Coverage 89.22% 89.25% +0.03%
==========================================
Files 149 149
Lines 13057 13057
==========================================
+ Hits 11650 11654 +4
+ Misses 1407 1403 -4
Impacted Files | Coverage Δ | |
---|---|---|
reproman/support/jobs/orchestrators.py | 94.23% <ø> (ø) |
|
reproman/interface/jobs.py | 97.08% <0.00%> (+0.97%) |
:arrow_up: |
reproman/interface/tests/test_run.py | 99.64% <0.00%> (+1.06%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8148fcd...2d7aa58. Read the comment docs.
cool, thanks @kyleam !
When 5f982f216 (2021-03-03) switched datalad-publish to datalad-push, data="auto" was used to retain the behavior of the publish() call. However, as mentioned in that commit and gh-575 [*], data="nothing" is preferable here. The original publish() call didn't use transfer_data="auto" because there was an intent to transfer data according to any configured preferred content; I just thoughtlessly left the option at the default value.
[*] https://github.com/ReproNim/reproman/pull/575#issuecomment-790090050