search

ReproNim / reproman

ReproMan (AKA NICEMAN, AKA ReproNim TRD3)
https://reproman.readthedocs.io
Other
24 stars 14 forks source link

BF: job_templates: Store launcher subjob output in expected files #579

Closed kyleam closed 3 years ago

kyleam commented 3 years ago

Submit templates direct subjob output to $metadir/{stdout,stderr}.{0,..,$subjobs - 1}. The recently added launcher handling, however, breaks this setup, creating just two files with all the output (one for stdout and one for stderr). In the case of Slurm, the output files are $metadir/{stdout,stderr}.4294967294 because the files are constructed with "%a", which gets set to the above value when there is no job array [1].

Rework launcher.template so that stdout and stderr are written to the expected files.

[1] https://slurm.schedmd.com/job_array.html

Re: #578

Thanks to @jdkent for reporting.

codecov[bot] commented 3 years ago

Codecov Report

Merging #579 (fac3267) into master (83e3bd6) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files         149      149           
  Lines       13070    13074    +4     
=======================================
+ Hits        11663    11667    +4     
  Misses       1407     1407
Impacted Files Coverage Δ
reproman/support/jobs/tests/test_orchestrators.py 94.76% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83e3bd6...fac3267. Read the comment docs.