search

ReproNim / reproschema-py

Apache License 2.0
2 stars 8 forks source link

adding id check to the validation #68

Closed djarecka closed 3 weeks ago

djarecka commented 4 months ago

@satra - I understand that response id also should be the same as name?

perhaps also wasAttributedFrom should be changes?

satra commented 4 months ago

only protocol, activity, and item as these are accessed via the web, hence the name needs to match the id in the jsonld file, not response or any other objects

djarecka commented 4 months ago

ok, changed it.

had to fix id names in some schema in the test/data

yibeichan commented 3 months ago

this PR is related to this issue #43, correct? is this one good to be merged?