search

ReproNim / reproschema-py

Apache License 2.0
2 stars 8 forks source link

Reproschema validate does not seem to check the validity of linked components #74

Closed ibevers closed 3 months ago

ibevers commented 3 months ago

This activity: https://raw.githubusercontent.com/sensein/b2aiprotocol/c201209f9d8f86991268bbfe78df7f2607f06e9c/generic/activities/q_generic_demographics/activities/optional/optional_schema

links to: https://raw.githubusercontent.com/sensein/b2ai-redcap2rs/main/activities/q_generic_demographics/items/household_income_usa

The current version of the reproschema validate command says that the optional directory is valid:

Screenshot 2024-08-19 at 12 32 28 PM

However, redcap2rs/main/activities/q_generic_demographics/items/household_income_usa does not contain a "variableName" field: https://raw.githubusercontent.com/sensein/b2ai-redcap2rs/5eb809faf56c75fb3e4f48da99075607f47cc3f2/activities/q_generic_demographics/items/household_income_usa

Note: I discovered this by tracing the following error in the ReproSchema UI:

Screenshot 2024-08-19 at 12 35 38 PM

The expectation of "variableName" is hardcoded in the UI: const qId = v['http://schema.repronim.org/variableName'][0]['@value'];

ibevers commented 3 months ago

I realized that the problem is that the activity does not have a variableName for the first item