search

ReproNim / reproschema-ui

UI to render ReproSchema based protocols and assessments.
https://www.repronim.org/reproschema-ui/
Other
3 stars 18 forks source link

Fixes for running b2aiprotocol #340

Closed ibevers closed 2 months ago

ibevers commented 3 months ago

I ran into a challenge similar to the one with the race item before, where the first element of arrays was getting extracted. Jordan and I came up with the fix in 8580a39 for it yesterday. It might have unintended side-effects, but so far, it doesn't seem to.

satra commented 3 months ago

can you create an example in demo-protocol to illustrate the issue? mostly because i thought this was no longer an issue. so there must a case where this still happens.

ibevers commented 3 months ago

Yes, it only seems to show up with nested activities. Since this fix unblocks me on interactively validating the mood protocol, I'm going to prioritize that over making a minimal example and giving a long explanation of the reasoning for this fix, but I will loop back to this.

satra commented 2 months ago

i'm closing this as this should have been fixed (and upgraded) in the PR that was merged #343