ReproNim / reproschema

A standardized form generation and data collection schema to harmonize results by design across projects.
https://www.repronim.org/reproschema/
Other
14 stars 20 forks source link

[REF] refactor documentation #487

Closed Remi-Gau closed 3 months ago

Remi-Gau commented 4 months ago

What this PR does:

Remi-Gau commented 4 months ago

Will try to extend the logic of this PR to extract all files examples from the doc into actual files so their content can be properly validated.

Because the user guide is based on the reproschema-demo-protocol: https://github.com/ReproNim/reproschema-demo-protocol I wonder if we should not sub-module it into this repo, so file content can directly be "injected" into the doc.

yibeichan commented 4 months ago

@Remi-Gau I finally have some time to think about our overall documentation; here is the plan: currently we have User Guide

Tutorial

We want to change User Guide to something more like a manual, probably we should have one page for each repo (e.g., reproschema, reproschema-library, reproschema-py, reproschema-ui, reproschema-protocol-cookiecutter), where we detail the usage of each repo (currently i can only think of reproschema-library, reproschema-py,reproschema-protocol-cookiecutter) for tutorials, we can merge Create a research protocol Adopt assessments from the library Create new assessments for a protocol in User Guide with Create a research protocol Creating a new activity in Tutorial the current Demographic information can be merged into Adopt assessments from the library the current Intro can be merged into Create a research protocol. if we want, we can write a new Intro

let me know what you think, we can meet and revise the plan, then split the task.

yibeichan commented 4 months ago

Because the user guide is based on the reproschema-demo-protocol: https://github.com/ReproNim/reproschema-demo-protocol I wonder if we should not sub-module it into this repo, so file content can directly be "injected" into the doc.

okay I found myself lost in this sentence, haha. so what do we want to do and what should not do here?

Remi-Gau commented 3 months ago

Will update the top message to explain what the PR does because otherwise future me is lost when he gets back to it

Remi-Gau commented 3 months ago

Validation fails because there is a README.md file in amongst the jsonld files but this should be fixed when https://github.com/ReproNim/reproschema-py/pull/40 is merged.

In the meantime I will run the validation with that branch from my fork.

yibeichan commented 3 months ago

use this branch for validation https://github.com/djarecka/reproschema-py/tree/ref/linkml

Remi-Gau commented 3 months ago

The user guide points to the demo protocol: if we update the demo protocol the user-guide may be out of synch with the content of the demo protocol repo.

May potentially be good to submodule the demo-protocol and read content directly from there.

Remi-Gau commented 3 months ago

Similarly some of the examples I have generated are based on some of the content from that PR https://github.com/ReproNim/reproschema-library/pull/60

So once this gets merged, we could use the same strategy of submoduling the library and read jsonld content directly from there: this may also allows us to give a listing of the content of the library as part of the documentation.

yibeichan commented 3 months ago

thank you!! @Remi-Gau i'm gonna merge this one now, once the new context URL is ready, I'll replace them. quick question: I saw all jsonld file has .jsonld extension, is it because we need this extension to help identify which file we want to validate (without .jsonld it would be hard to know which is which)? but in general, we don't add .jsonld in reproschema

Remi-Gau commented 3 months ago

we don't add .jsonld in reproschema

Let me turn the question around: why is it not the case?