search

ReproNim / reproschema

A standardized form generation and data collection schema to harmonize results by design across projects.
https://www.repronim.org/reproschema/
Other
15 stars 21 forks source link

add `maxLength` back for string type responses #535

Open satra opened 3 months ago

satra commented 3 months ago

In some protocols, we have an maxLength property for text inputs. It would be good to add this one back to ResponseOption, unless we think we can use maxValue, but that doesn't seem semantically correct for a string type input.

just a note that this variable does not seem to be used in the UI at the moment.

yibeichan commented 1 month ago

@djarecka i'm trying to understand how this works. so we should add maxLength to linkml-schema/reproschema.yaml and then everything will generate automatically, right?

djarecka commented 1 month ago

The new version of the pydantic schema should be generated when running validate_and_release GA, and this is workflow has to be manually triggered. Look at the README and update if something is not clear.

fyi. with newer linkml you might have to update the command (removing --pydantic-version 2)