quotes in quotes, remove parens, ...

Reptudn / minishell

The objective of this project is for you to create a simple shell.

1 stars 1 forks source link

quotes in quotes, remove parens, ... #85

Closed Reptudn closed 7 months ago

Reptudn commented 7 months ago

[x] when a quote is in a quote then dont remove those inside
[x] when encountering open or close parens just remove them when splitting (only if they are not in quotes ofc)
[ ] figure out how to correctly handle heredoc because as an example echo << EOF should just print a nl and cat << EOF the content of the heredoc. right now both just print the heredoc output because its saved inside an echo cmd
[x] other stuff that were issues before...

Reptudn commented 7 months ago

bash

minishell

Reptudn commented 7 months ago

git fetch origin git checkout 85-big-chungus-fixes

NoelSabia commented 7 months ago

when a quote is in a quote then dont remove those inside

regarding this "problem" i dont think there is any problem. the reason for that is following: bash: echo "hi how"are you"

(basically acts like heredoc then so not wrong) it actually behaves the same in our shell. so no problemo

Reptudn commented 7 months ago

No there is an issue. You just got it wrong.

in bash:

in minishell:

Reptudn commented 7 months ago

there is also an issue that i will fix that is when we get echo '"$USER"' and the split works correctly we get this in the end echo "$USER" that doesnt count as a variable cuz its directly surrounded by quotes