search

RequestNetwork / request-apps

Request network Dapps monorepo
MIT License
5 stars 12 forks source link

Request Create fails to fetch balance for MATIC requests #60

Closed MantisClone closed 6 months ago

MantisClone commented 1 year ago

Problem

Display bug: MATIC requests display "Creating Request" forever.

Analysis

Status is based on request.data.balance.balance but in the case of MATIC requests, the balance is null due to error:

"processing response error (body="{\"status\":\"0\",\"message\":\"NOTOK\",\"result\":\"Invalid API Key\"}", error={"result":"{\"status\":\"0\",\"message\":\"NOTOK\",\"result\":\"Invalid API Key\"}"}, requestBody=null, requestMethod="GET", url="https://api.polygonscan.com/api?module=account&action=txlist&address=0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567&startblock=0&endblock=99999999&sort=asc&apikey=9D13ZE7XSBTJ94N9BNJ2MA33VMAY2YPIRB", code=SERVER_ERROR, version=web/5.5.0)"

image

Solution

Upgrade Request Create app to allow setting a private Polygonscan API key instead of using the default API key provided by ethers

Migrated from Asana: https://app.asana.com/0/1203912381456855/1205300974037142/f

GHkrishna commented 11 months ago

Hey @MantisClone

I tried working with the URL. Actually, polygon allows access to transaction data without necessarily providing the API key.

So in this case would the API key be necessary?

We could have a request without the key.

MantisClone commented 11 months ago

@GHkrishna If you're able to remove the need for the API key entirely, that would be great. :+1: Just be sure not to break any of the other chains that may still require an API key.

MantisClone commented 6 months ago

https://github.com/RequestNetwork/request-apps/issues/67#issuecomment-2085741704

We decided to deprecate and shut down Request Create

https://github.com/RequestNetwork/request-apps/issues/75