RequestNetwork / requestNetwork

A JavaScript library for interacting with the Request Network protocol
https://docs.request.network/
MIT License
381 stars 72 forks source link

Add utilities for preparing Conversion payments #1337

Open MantisClone opened 9 months ago

MantisClone commented 9 months ago

Problem

Builders have experienced difficulty integrating Conversion, Swap-to-pay, and Swap-to-conversion payments due to the lack of utilities or templates for preparing transactions.

Solution

~Open source the utilities that Request Finance uses to prepare Conversion, Swap-to-pay, and Swap-to-Conversion payments.~ Add utilities to the RN SDK for preparing Conversion payments.

Definition of Done

Reference

These are the utilities written by Request Finance. We've since discovered that they're not as reusable as originally thought.

MantisClone commented 5 days ago

I'm reducing the scope by removing swap-to-conversion because we discovered that swap-to-conversion is not supported by the SDK at all. Adding swap-to-conversion to the SDK is a larger task and should be tracked separately. I created https://github.com/RequestNetwork/requestNetwork/issues/1469 to track.

MantisClone commented 5 days ago

@rodrigopavezi added Conversion to Request Invoicing in https://github.com/RequestNetwork/web-components/issues/76. While doing so, he discovered that the utilities from Request Finance are not as easy to reuse as @MantisClone originally thought. So he ended up implementing his own utilities for preparing Conversion payments.

The scope of this task has changed to formalizing the Conversion utilities that @rodrigopavezi developed by adding them to the RN SDK.