RequestNetwork / web-components

A collection of Web Components for quickly integrating Request Network into your app.

https://docs.request.network

1 stars 3 forks source link

Fix the automated release process #29

Closed MantisClone closed 3 hours ago

MantisClone commented 3 months ago

Problems

The release-if-necessary Github Workflow fails. Example. It should automatically deploy packages to NPM when their version number increases.
Upgrading inter-package dependencies is prone to human error

Definition of Done

[x] Fix the release-if-necessary Github Workflow.
[x] ~~Automate upgrading inter-package dependencies so they're always using the latest versions of each package.~~ Unnecessary after #41

MantisClone commented 2 months ago

On hold until #41 is complete due to conflicting work on shared package.

MantisClone commented 2 months ago

Unfortunately, the release process is still broken and we're unsure why. https://github.com/RequestNetwork/web-components/actions/runs/9944543070

Publish logs

``` Run npm config set registry https://registry.npmjs.org/ npm config set registry https://registry.npmjs.org npm publish --workspace=@requestnetwork/create-invoice-form shell: /usr/bin/bash -e {0} env: NPM_CONFIG_USERCONFIG: /home/runner/work/_temp/.npmrc NODE_AUTH_TOKEN: XXXXX-XXXXX-XXXXX-XXXXX > @requestnetwork/create-invoice-form@0.6.0 prepublishOnly > npm run package > @requestnetwork/create-invoice-form@0.6.0 package > svelte-kit sync && svelte-package && npm run build:wc && publint Your compilerOptions.paths in tsconfig.json should include the following: { "$lib":["./src/lib"], "$lib/*":["./src/lib/*"] } src/lib -> dist @sveltejs/package found the following issues while packaging your library: You are using Svelte components or Svelte-specific imports in your code, but you have not declared a dependency on `svelte` in your `package.json`. Add it to your `dependencies` or `peerDependencies`. > @requestnetwork/create-invoice-form@0.6.0 build:wc > vite build -c vite.wc.config.ts vite v4.5.3 building for production... transforming... 6:19:35 PM [vite-plugin-svelte] /home/runner/work/web-components/web-components/packages/create-invoice-form/src/lib/invoice/form.svelte:470:[2](https://github.com/RequestNetwork/web-components/actions/runs/9944543070/job/27470818778#step:8:2) Unused CSS selector "button" 468: } 469: 470: button { ^ 471: background: transparent; 472: border: none; 6:19:35 PM [vite-plugin-svelte] /home/runner/work/web-components/web-components/packages/create-invoice-form/src/lib/invoice/form.svelte:531:2 Unused CSS selector ".invoice-form-dates input" 529: } 530: 531: .invoice-form-dates input { ^ 532: width: 100%; 533: } 6:19:35 PM [vite-plugin-svelte] /home/runner/work/web-components/web-components/shared/components/dropdown.svelte:42:2 A11y: visible, non-interactive elements with an on:click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as

MantisClone commented 3 weeks ago

Unfortunately, the release process is still broken, even after https://github.com/RequestNetwork/web-components/pull/89 Example

MantisClone commented 3 hours ago

Reopening

[ ] Add payment-widget
[ ] Make sure release to NPM works

MantisClone commented 57 minutes ago

Finally, the automated release process works :tada: We tested that the payment-widget was released to NPM correctly :white_check_mark:

We didn't test add-stakeholder, create-request-form, or invoice-dashboard. We're assuming it works for them too.