search

RequestPolicy / requestpolicy

RequestPolicy is a Firefox extension that gives you control over cross-site requests. --- Be sure to look at the dev-1.0 branch as that's where all of the interesting work is happening. See also: https://www.requestpolicy.com/1.0.html
https://www.requestpolicy.com/
107 stars 17 forks source link

Norton toolbar conflict again. Firefox 5 / Firefox 6 / NIS Toolbar 2011 / Request Policy 0.5.22b2 #240

Open jsamuel opened 12 years ago

jsamuel commented 12 years ago 
imported trac ticket
created: 2011-06-28 12:56:48
reporter: davemab2287

Upgrading Firefox 3 to Firefox 5 causes Request Policy 0.5.21 to break the display in the Norton Toolbar version 5.6. (Norton Engine version 18.6.0.29). The icons and boxes are missing although clicking the blank spaces brings up drop down menus. The workaround is exactly the same as described in ticket 57 (closed). In RequestPolicy preferences enable 'Temporarily Allow All Requests' when browser starts. However I cannot see the point of having this startup mode. It is not much better than having RequestPolicy disabled completely. In the RequestPolicy latest version 0.5.21 Components / Request Policy Service there is a reference to the Norton Safe Web Lite Toolbar IDArray {203FB6B2-2E1E-4474-863B-4C483ECCE78E}. The actual toolbar is Toolbar 5.6 in NIS 2011 with engine version 18.6.0.29 (in Programs) and has the IDArray {0C55C096-0F1D-4F28-AAA2-85EF591126E7} for the toolbar in All Users / Application Data (version 18.5.0.125). Why the different versions I have no idea. Perhaps the reason for the conflict, RequestPolicy is trying to make the Add-on compatible with an outdated toolbar.

jsamuel commented 12 years ago 
imported trac comment
created: 2011-07-02 17:57:25
author: eibwen

Rather than trying to account for all requests made by all extensions -- and as this bug illustrates, all versions of all extensions -- we should expose chrome requests to the user and let the user decide their own policy.

Granted, if possible, it would be helpful to the user to trace the originating extension that generated the request for ease of policy determination.

jsamuel commented 12 years ago 
imported trac comment
created: 2011-07-06 18:23:28
author: justin

Attempted fix in r447. Using the same compatibility rules for NIS Toolbar as RP currently uses for the Norton Safe Web Lite Toolbar because it sounded like the same requests were being blocked, according to additional info by email from davemab2287. Specifically, requests to "symnst:" URLs are being blocked, so this patch allows all requests to those when the NIS Toolbar is installed.

Unfortunately, I don't have a copy of NIS at the moment so can't test this patch. It's a fairly simple patch and so I highly doubt it can cause additional breakage. However, it will be good to know if it does solve the problem. I'll update this ticket when a beta build of RP 0.5.22 is ready (probably later today).

jsamuel commented 12 years ago 
imported trac comment
created: 2011-07-06 18:35:11
author: justin

The beta version of the next release of RP is now available here:

https://www.requestpolicy.com/releases/requestpolicy-0.5.22b1.xpi

@davemab2287 if you get a chance to test this, please let me know if the conflict is resolved. Thanks!

jsamuel commented 12 years ago 
imported trac comment
created: 2011-07-07 06:05:25
author: davemab2287

Hi Justin. '''RequestPolicy 0.5.22b1''' Unfortunately your patch has not resolved the issue. In RequestPolicy preferences I still have to enable 'Temporarily Allow All Requests' when browser starts to allow Norton's toolbar to display correctly. Today Norton updated their toolbar from version 5.6 to version 2011.7.0.8 but I do not know if this makes any difference to the patch you added in RequestPolicy. I checked in RequestPolicy 0.5.22b1 under Components / Request Policy Service and I see the toolbar ID {0C55C096-0F1D-4F28-AAA2-85EF591126E7} line that you have added. That ID has remained within C:\Documents and Settings\All Users\Application Data\Norton{0C55C096-0F1D-4F28-AAA2-85EF591126E7} after Norton updated their toolbar in Firefox. As well as reloading Firefox I have also reloaded the computer but that has had no effect.

'''eibwen''' I wasn't quite sure what eibwen had in mind .... 'we should expose chrome requests to the user and let the user decide their own policy'. I would be quite capable of changing the toolbar ID within RequestPolicy Components / Request Policy Service when Norton changes this ID and whist I could figure out how to add new code I do not feel that it would be responsible for the user to do so. If the add-on had options included within the interface I could see some advantage.

jsamuel commented 12 years ago 
imported trac comment
created: 2011-07-07 10:52:51
author: justin

Ok, I think it's really fixed now with r448. I was finally able to test on Windows 7 with a trial version of NIS 2011. It seems the extension ID is different and there is an additional scheme they've registered for resources ("symres:").

A new beta is available here which includes the fix,

https://www.requestpolicy.com/releases/requestpolicy-0.5.22b2.xpi

Thanks for your patience, davemab2287. Let me know if this doesn't fix the extension conflict for you.

jsamuel commented 12 years ago 
imported trac comment
created: 2011-07-07 14:53:59
author: davemab2287

This fix now resolves the issue. I am pleased that you managed to get a copy of NIS. Thank you for the time you have put aside to resolve this.

jsamuel commented 12 years ago 
imported trac comment
created: 2011-07-08 08:41:37
author: justin

Great, thanks for confirming this is working now.

jsamuel commented 12 years ago 
imported trac comment
created: 2011-08-17 03:18:05
author: davemab2287

Firefox 5.0.1 and Firefox 6.0

Norton Toolbar 2011.7.0.8 - previous toolbar that r448 fixed Norton Toolbar 2011.7.1.3 - latest toolbar 17-Aug-11 that requires an amendment to r448

With the new 6 week turn round of Firefox updates Request Policy is again preventing the latest Norton Toolbar from displaying properly in Firefox 5.0.1 and Firefox 6.0

Please note that the toolbar display in Firefox 6.0 has not been checked because when I upgraded to Firefox 6.0 Norton had not quite released the new compatible toolbar. I had to revert back to Firefox 5.0.1 anyway because so many add-ons had become incompatible.

jsamuel commented 12 years ago 
imported trac comment
created: 2011-08-17 12:50:41
author: davemab2287

The latest Norton Toolbar is now displaying correctly when I upgraded to Firefox 6. It only seems to display incorrectly for those who are still using Firefox 5.0.1 with the new Norton toolbar. I am not sure if this still requires you to make any adjustment as some users will still be using the older Firefox version until all the add-ons become compatible.

jsamuel commented 12 years ago 
imported trac comment
created: 2011-09-03 16:18:13
author: justin

Ideally I would have fixed this for Fx 5.0.1 but I didn't have time and by now most users are on Fx 6. So, closing this ticket.

jsamuel commented 12 years ago 
imported trac comment
created: 2011-09-13 13:07:03
author: davemab2287

Firefox 6.0.2 and Request Policy 0.5.23b2 and Norton 2012.1.0.30 Toolbar Unfortunately the fix that has been applied in Request Policy is causing the Norton display to behave erratically again. I am unable to determine what is causing this but sometimes the Norton Toolbar will display fine in Firefox 6 and a few minutes later it is broken again. It seemed to have happened when I changed an option in Norton to allow Safe Surfing buttons to appear in Google results. Unfortunately the facility does not work any longer (it did before) but then the toolbar didn't display correctly like before either. I think that RP may be interfering with the Norton Safety button display in Google results now also but I have not carried out checks to confirm this. I tried re-starting Firefox several times after changing the option back and forth but nothing seems to have brought back the display. Perhaps the upgrade to Firefox 6.0.2 and Norton 2012 has something to do with it.

EDIT: I can now confirm .......

  1. That disabling RP then the Norton 2012 Toolbar displays correctly.
  2. That disabling RP has no effect in allowing the Norton Safe Surfing Safety Buttons to display in Google results. The buttons will still not display. That seems to be a separate issue.

EDIT: Since disabling RP / restarting FF & re-enabling RP / restarting FF I can now confirm that the Norton Toolbar 2012 is displaying correctly again, but that is with Norton Safe Surfing disabled (if that has any bearing on the problem).

EDIT: Also disabling Norton 2012 Toolbar / restarting FF and then re-enabling Norton 2012 Toolbar / restarting FF achieves the same effect and resolves the toolbar display problem temporarily.

EDIT: After disabling all add-ons including the Site Advisor Plugin but just leaving Norton Safe Surfing enabled, the Norton Safe Surfing buttons do not work and no buttons are displayed in Google results, so the issue with regard to Norton Buttons has no bearing whatsoever on the compatibility issue between RP and the Norton 2012 toolbar display problem.

After all these re-starts the Norton toolbar is displaying fine at the moment!

PS Thank you for sorting the email issue.