search

RequestPolicyContinued / requestpolicy

a web browser extension that gives you control over cross-site requests. Available for XUL/XPCOM-based browsers.
https://github.com/RequestPolicyContinued/requestpolicy/wiki
Other
252 stars 35 forks source link

[CLOSED] toolbar button does not work when status bar is disabled #25

Closed msxfm closed 10 years ago

msxfm commented 10 years ago

Issue by jsamuel Thursday Dec 22, 2011 at 18:46 GMT Originally opened as https://github.com/RequestPolicy/requestpolicy/issues/25

imported trac ticket
created: 2009-07-26 20:24:43
reporter: justin

If the status bar is not enabled (that is, if one goes to the Firefox "View" menu and disables the status bar), the !RequestPolicy toolbar button does not work. The error that results from clicking on the toolbar button is:

{{{ Error: this._menu.openPopup is not a function Source file: chrome://requestpolicy/content/overlay.js Line: 1295 }}}

msxfm commented 10 years ago

Comment by jsamuel Thursday Dec 22, 2011 at 18:46 GMT

imported trac comment
created: 2010-10-07 12:43:51
author: rainer

FF 4.0b8pre here

Since this Firefox 4 has the status bar disabled by default, with the default settings there is no way to use RequestPolicy.

Here, clicking the tool bar button with the status bar disabled does not cause any messages in the error console.

msxfm commented 10 years ago

Comment by jsamuel Thursday Dec 22, 2011 at 18:46 GMT

imported trac comment
created: 2010-10-07 15:09:49
author: rainer

Replying to [comment:2 rainer]:

with the default settings there is no way to use RequestPolicy.

Well, of course, there is still the right-click menu, I forgot that (I very rarely use the RP menu there).

BTW:

msxfm commented 10 years ago

Comment by jsamuel Thursday Dec 22, 2011 at 18:46 GMT

imported trac comment
created: 2010-11-12 09:20:24
author: justin

This problem is now more urgent with Fx 4, which has a separate "addons bar" instead of a status bar and the addons bar is disabled by default. As a result, people with the toolbar button in use but the status bar enabled will find that RP seems to no longer work after they upgrade to Fx 4. Those users who don't use the toolbar icon and instead will go hunt down how to enable the addons bar in Fx 4 will be fine.

msxfm commented 10 years ago

Comment by jsamuel Thursday Dec 22, 2011 at 18:46 GMT

imported trac comment
created: 2010-11-12 09:27:46
author: justin

And, thanks rainer, for drawing attention to this. The big issue here is that making the status bar/toolbar/context menu code all work correctly was initially a giant pain in the XUL. So, if this remains unfixed for a while still, it's because it may turn out to be a big time sink of fiddling and testing with all sorts of Firefox and !SeaMonkey versions.

msxfm commented 10 years ago

Comment by jsamuel Thursday Dec 22, 2011 at 18:46 GMT

imported trac comment
created: 2010-12-24 08:38:46
author: tallus

Replying to [comment:5 justin]:

And, thanks rainer, for drawing attention to this. The big issue here is that making the status bar/toolbar/context menu code all work correctly was initially a giant pain in the XUL.

As an adddendum to all this if you have the add-on bar enabled in FF4 beta but doing any styling of it (i.e. with CSS via stylish) you end up with a zero height menu: the menu pops up with scroll bars at top and bottom but nothnig else visible.

msxfm commented 10 years ago

Comment by jsamuel Thursday Dec 22, 2011 at 18:46 GMT

imported trac comment
created: 2010-12-29 13:37:29
author: justin

This is fixed in r366. This change will be in RP 0.5.17a1.

I really thought the fix would be harder because I thought I had tried this solution before. Seems to work in Fx 3.0, 3.6, 4.0b9pre and !SeaMonkey 2.0, 2.1b1.