search

RequestPolicyContinued / requestpolicy

a web browser extension that gives you control over cross-site requests. Available for XUL/XPCOM-based browsers.
https://github.com/RequestPolicyContinued/requestpolicy/wiki
Other
252 stars 35 forks source link

Redirect adds wrong rule #809

Open kkeane opened 8 years ago

kkeane commented 8 years ago

This issue is similar but not the same as #808

When a page redirects, RP will offer three options "Allow" "Deny" and "Add Rule" The third option will end up denying the redirect even if you want it allowed. It will also sometimes add the wrong rule (I will report this as a separate issue).

One site where this problem is extensively noticeable is http://www.codeproject.com/script/News/List.aspx

  1. Clear any RP rules related to codeproject.com
  2. Visit the Web site http://www.codeproject.com/script/News/List.aspx
  3. Right-click on one of the story links from one site (let's call it xxx.com) and select "Open in New Tab"
  4. Right-click on a second story link from a different site (let's call that yyy.com) and again select "Open in New Tab"

At this point, there should be two new tabs, both with "Allow" Deny" and "Add Rule" buttons.

  1. Visit the first of the new tabs
  2. Select "Add Rule" Expected result The drop-down should offer to add a rule for "Allow from codeproject.com to xxx.com" Actual result The drop-down offers to add a rule for "Allow from codeproject.com to yyy.com"

Note: all of the tabs will simply offer to add a rule for whatever site the last one redirected to.

myrdd commented 8 years ago

Thank you, I can confirm this issue.

The popup content should be populated when the "Add Rule" button is clicked, not when the notification bar is created.