search

Research-IT-Swiss-TPH / redcap-pdf-injector

PDF Injector is a REDCap module that enables you to populate fillable PDFs with record data from variables.
https://research-it-swiss-tph.github.io/redcap-pdf-injector/
MIT License
7 stars 8 forks source link

[Feature request] Add QuickFill Button to Step 2 in Injection Edit Modal #9

Closed ThomasVermes closed 3 years ago

ThomasVermes commented 3 years ago

image

Would be nice that after importing the pdf, the "redcap filed" will automatically fulfilled with the "pdf field". It can still be adjusted in case of corrections.

tertek commented 3 years ago

This is an anti-pattern, since not every user is going to name the form fields the same way as the variables. Defining the placeholder in this way could suggest that variables should be defined equal to form field names. This is not best practise and can be confusing for new users.

ThomasVermes commented 3 years ago

Opposite, I really think the best practice would be to rename both of the fields in the same way to avoid confusion an to facilitate the mapping.

From: "tertek" @.> To: "tertek/redcap-pdf-injector" @.> Cc: "ThomasVermes" @.>, "Author" @.> Date: 07.09.2021 09:44 Subject: Re: [tertek/redcap-pdf-injector] [Feature request] Automatic recognizion of field name (#9)

This is an anti-pattern, since not every user is going to name the form fields the same way as the variables. Defining the placeholder in this way could suggest that variables should be defined equal to form field names. This is not best practise and can be confusing for new users. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error, please notify us immediately by reply e-mail and delete this message from your system.

tertek commented 3 years ago

Additionally, variable validation is asynchronously. Setting a default placeholder would break the whole validation procedure/experience.

ThomasVermes commented 3 years ago

Set a button which can copy automatically all the field name after the import and procedure/experience?

From: "tertek" @.> To: "tertek/redcap-pdf-injector" @.> Cc: "ThomasVermes" @.>, "Author" @.> Date: 07.09.2021 09:50 Subject: Re: [tertek/redcap-pdf-injector] [Feature request] Set variable placeholder to form field slug (#9)

Additionally, variable validation is asynchronously. Setting a default placeholder would break the whole validation procedure/experience. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error, please notify us immediately by reply e-mail and delete this message from your system.

tertek commented 3 years ago

Same problem with validation. Too many edge cases. Not worth the effort. Why not just copy & paste?

ThomasVermes commented 3 years ago

We could have docs with 50, 100 variables and the doc might also be corrected or changed often. That results in a really time consuming task.

From: "tertek" @.> To: "tertek/redcap-pdf-injector" @.> Cc: "ThomasVermes" @.>, "Author" @.> Date: 07.09.2021 10:26 Subject: Re: [tertek/redcap-pdf-injector] [Feature request] Set variable placeholder to form field slug (#9)

Same problem with validation. Too many edge cases. Not worth the effort. Why not just copy & paste? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error, please notify us immediately by reply e-mail and delete this message from your system.

tertek commented 3 years ago

Added in https://github.com/tertek/redcap-pdf-injector/releases/tag/v1.3.4