search

Research-Support-Network / research-support-network.github.io

https://research-support-network.github.io
Creative Commons Zero v1.0 Universal
2 stars 2 forks source link

Add Benjamin Krikler - Uni. of Bristol (Visiting research) / RemotelyGreen SA / Independent #193

Closed research-support-network[bot] closed 2 years ago

research-support-network[bot] commented 2 years ago

Dear human,

Here's a new entry for your approval. :tada:

Merge the pull request to accept it, or close it to send it away.

:heart: Your friend Staticman :muscle:

Field Content
name Benjamin Krikler
affiliation Uni. of Bristol (Visiting research) / RemotelyGreen SA / Independent
timezone Europe/Brussels
email mr [dot] krikler+rse [at] gmail [dot] com
website https://krikler.be
languages English, Portuguese, French
expertise python, c++, javascript, bash, machine learning, pre-processing, visualisation, particle physics, git, simulations
WhoIsJack commented 2 years ago

@unode Looks like a / in affiliation, which gets included in the file name, causes the file to be interpreted as a directory. Any way to handle this systematically?

unode commented 2 years ago

I'm afraid we will have to implement something in JavaScript to reject / and possibly other special characters. I can't find any documentation on staticman that could be of use here.

WhoIsJack commented 2 years ago

Ok, I see. There's a bunch of code snippets out there for this kind of stuff, but it's hard to say which are the most robust.

In the meantime, I'll see if I can fix this one manually.

WhoIsJack commented 2 years ago

Manual fix complete; closing this.

Todo: prevent special chars (esp. slashes; dashes and brackets should probably be kept) in name and affiliation.

unode commented 2 years ago

@WhoIsJack attempt to prevent this in the future added in cdd13e38a91dcb1a8065554b2a1e652a8d1d4b0c

WhoIsJack commented 2 years ago

@unode

Just got an email that someone was unable to submit with "Please match the requested format."

There are slashes in the expertise (and of course in the time zone), but nowhere else. Could you maybe just apply the restriction to name and affiliation, which end up being part of the file name? I think people should be able to use slashes in the expertise. Also, we'll need to add a little note to the affected fields saying "no special characters".

edit: actually, now that I've looked at your commit, I think the issue is not that it is misapplied to Expertise - must be something else: opened an issue!