Research-Support-Network / research-support-network.github.io

https://research-support-network.github.io
Creative Commons Zero v1.0 Universal
2 stars 2 forks source link

Unexpected Effects of Special Char Restrictions #197

Closed WhoIsJack closed 2 years ago

WhoIsJack commented 2 years ago

I think they should only affect Name and Affiliation, as they're the fields that end up in file names. See also #193.

WhoIsJack commented 2 years ago

Just checked your implementation, @unode, and it seems that it's actually already specific to name and affiliation.

Not sure what is going wrong then?

Here's the rejected submission:

Name: Jim Pivarski
Affiliation: Princeton University
Timezone: America/Chicago
E-mail: [pivarski@princeton.edu](mailto:pivarski@princeton.edu)
Website (optional):
Languages: English and written (non-verbal) French
Expertise (less than 400 characters): Python/NumPy, interface with C/C++, performance optimization, parallel processing, basic GPU programming (Nvidia CUDA), functional programming (immutable data structures, Scala), basic git/GitHub, Linux commandline, data analysis techniques (exploratory EDA, regression, clustering, decision trees, basic machine learning/ML), statistics (confidence intervals, hypothesis testing), particle physics.
WhoIsJack commented 2 years ago

Reverted your change for now and pushed the above submission through; worked as expected.

unode commented 2 years ago

The issue seems to be that spaces were not allowed in the pattern. But like spaces there may be other characters that should perhaps be allowed. I'll try to invert the pattern and instead deny only problematic characters.

unode commented 2 years ago

Pushed [^\/]{1,100} now in c5df2b43cde480cabc1b3f81ff6821a7f3162174 Tested locally and it passed. I believe before it was also forcefully expecting 100 characters.

Apologies for this, it may have prevented some people to sign up yesterday :cry:

WhoIsJack commented 2 years ago

Thanks for the fix, Renato! Inverting the pattern seems like a very good solution. 👍

St*ff happens; no worries. We didn't get any other emails, so people may have just tried again a bit later, when I had already reverted it. 😌

unode commented 2 years ago

Thanks for the quick action on your part :rocket: