search

ResearchObject / ro-crate-py

Python library for RO-Crate
https://pypi.org/project/rocrate/
Apache License 2.0
49 stars 27 forks source link

Type annotations #196

Open multimeric opened 2 months ago

multimeric commented 2 months ago

I rely pretty heavily on type annotations, and I envisage using ro-crate-py a lot in the near future. Would you be open to me submitting a PR that adds type annotations to the library?

If this is okay, could I bump the minimum Python version from 3.7 to 3.9? 3.7 has been EOL for a while, and 3.8 will be EOL just over a week: https://devguide.python.org/versions/. The reason this matters is that it unlocks better type syntax such as list[str].

simleo commented 2 months ago

Would you be open to me submitting a PR that adds type annotations to the library?

OK, thank you!

could I bump the minimum Python version from 3.7 to 3.9

Already done that in #200