search

ResearchObject / ro-crate-validator-py

Python-based RO-Crate validator (alpha)
Apache License 2.0
3 stars 1 forks source link

Licence is incorrectly rejected #1

Open bronger opened 1 year ago

bronger commented 1 year ago

I have trouble validating my crate due to the second term at https://github.com/ResearchObject/ro-crate-validator-py/blob/c3c5c18509c00ff51a96d430ed5ba5dc3e50b86c/src/rocrateValidator/semanticCheck.py#L581 It excludes the root data entity but shouldn’t only ro-crate-metadata.json be excluded?

a-mile commented 1 year ago

@bronger I think that is correct. I'm attaching a valid URL license to the root data entity and always getting an IDError result from upd_licenseRlt. I would like to understand why that second part of the if statement is necessary.

wragge commented 1 year ago

I'm not clear on why you can't have a license on ro-crate-metadata.json either. I'm following the pattern here to attach a separate CC0 license for the metadata itself: https://www.researchobject.org/ro-crate/1.1/contextual-entities.html#metadata-license