ResearchObject / ro-crate

Research Object Crate
https://w3id.org/ro/crate/
Apache License 2.0
79 stars 34 forks source link

Delete renamed classes from JSON-LD context? #120

Open marcolarosa opened 3 years ago

marcolarosa commented 3 years ago

I'm creating a profile in describo to drive the UI from schema.org. In that process I rename all instances of MediaObject to File so the user can't add / associate a type of MediaObject; rather, they only get the option to add / associate a File. However, the RO-crate context has an entry for File and MediaObject.

So:

I guess this holds true for other examples that have been renamed but I haven't come across any myself.

stain commented 3 years ago

I think we only keep MediaObject because it is in the original context - it's not deleted.

https://github.com/ResearchObject/ro-crate/blob/master/docs/1.1/context.jsonld#L603

Perhaps it should be deleted? This could also help JSON-LD flattening so it does not accidentally pick the other one, and our spec do say it is renamed.

The renames from PCDM are only there in the renamed variant:

          "RepositoryCollection": "http://pcdm.org/models#Collection",
          "RepositoryObject": "http://pcdm.org/models#object",

In addition Journal is renamed from Periodical, but it is also there natively:

          "Journal": "http://schema.org/Periodical",
          "Periodical": "http://schema.org/Periodical",
marcolarosa commented 3 years ago

My code is renaming classes so MediaObject cannot be added via describo but File can. That said, when flattening it could come out as either as you rightly point out.

You mention Journal being renamed. I didn't know that. Is there an authoritative list of these renames in the documentation that I can consult?