ResearchObject / ro-crate

Research Object Crate
https://w3id.org/ro/crate/
Apache License 2.0
79 stars 34 forks source link

Unreadable SVG in introduction documentation #294

Closed ShrimpCryptid closed 2 months ago

ShrimpCryptid commented 3 months ago

Describe the bug SVG in the introduction section seems to show an image and additional text, making it unviewable.

image

URL Documentation page: https://www.researchobject.org/ro-crate/1.2-DRAFT/introduction.html Direct link to the SVG: https://www.researchobject.org/ro-crate/assets/img/crate1-folders.svg

Suggested fix Place the text beneath the image layer or remove it from the SVG? (I'm not sure if aria-label or the text is preferred here if it was included for accessibility.)

Additional context I also dug through the SVG HTML and it looks like it was exported from Inkscape (💖) with all of the Inkscape metadata. It likely doesn't matter for an SVG this small, but it can be helpful to export as an Optimized SVG for file size, which will strip out some of the extra data.

stain commented 2 months ago

Thanks - which browser did this happen in? It was a poor attempt to make the graphic glyphs of the text selectable (e.g. readable by the sight impaired), but as you see the rendering as text will easily get the wrong font, so the text layer was meant to be transparent and only the glyphs showing.

So if we could find a way to make the text transparent in your browser as well that would be ideal, otherwise, at least for this one, we should probably just delete the text.

Is the problem there also in https://www.researchobject.org/ro-crate/assets/img/introduction-figure-2.svg and https://www.researchobject.org/packaging_data_with_ro-crate/fig/crate1-folders.svg ?

ShrimpCryptid commented 2 months ago

Thanks - which browser did this happen in? It was a poor attempt to make the graphic glyphs of the text selectable (e.g. readable by the sight impaired), but as you see the rendering as text will easily get the wrong font, so the text layer was meant to be transparent and only the glyphs showing.

So if we could find a way to make the text transparent in your browser as well that would be ideal, otherwise, at least for this one, we should probably just delete the text.

Is the problem there also in https://www.researchobject.org/ro-crate/assets/img/introduction-figure-2.svg and https://www.researchobject.org/packaging_data_with_ro-crate/fig/crate1-folders.svg ?

The links you posted work just fine, no issues there!

I'm on Chrome (Version 123.0.6312.106 (Official Build) (64-bit)) on Windows 10.