search

ResearchObject / workflow-run-crate

Workflow Run RO-Crate profile
https://www.researchobject.org/workflow-run-crate/
Apache License 2.0
8 stars 9 forks source link

Remove individual roterms from profile crates #83

Open stain opened 3 months ago

stain commented 3 months ago

From https://github.com/ResearchObject/workflow-run-crate/pull/73#issuecomment-2188843732

I think if the terms are defined now properly in the roterms namespace (incl. HTML!) we no longer need to define them individually in the profile crates, just refer to the DefinedTermSet alone. Will raise as new issue for 0.6, that's just housekeeping, no harm in the current way except duplication.

So suggestion is to remove each of the DefinedTerm to avoid this sublisting in https://github.com/ResearchObject/workflow-run-crate/blob/main/docs/profiles/0.6-DRAFT/process_run_crate/ro-crate-metadata.json#L329 and each DefinedTerm reference as that will essentially be re-declaring what is now deployed on https://w3id.org/ro/terms/workflow-run and we no longer need ad-hoc definitions in our Profile Crates.

Instead there will just be a DefinedTermSet reference only, as specified in https://www.researchobject.org/ro-crate/specification/1.2-DRAFT/profiles.html#extension-vocabularies