Add Title, Image, and Date to social shares

ResistanceCalendar / resistance-calendar-frontend

A central listing of upcoming progressive events

https://resistance-calendar-staging.herokuapp.com/

MIT License

7 stars 8 forks source link

Add Title, Image, and Date to social shares #101

Closed sdotson closed 7 years ago

sdotson commented 7 years ago

For #97 .

sdotson commented 7 years ago

@dorono, good eye! Since the buttons don't work with localhost, I temporarily put in an arbitrary image url (the logo on staging/heroku server) to do the screenshot. The code as it stands now in this PR should be taking the featuredImageUrl being used in the EventDetails component and passing it down as a prop to SocialBtns

pdw207 commented 7 years ago

Great job! Thanks.

sdotson commented 7 years ago

I've addressed all comments but noticed something with the new facebook app id: The share dialogue won't work with everybody unless we make the app public. If it's too early for that we can designate a few testers for the app and it'll work for them.

Below are screenshots of what I see when I click facebook share now and where one could change the setting to make the app public in facebook (using a screenshot of my test app as an example).

pdw207 commented 7 years ago

Try it now.

sdotson commented 7 years ago

Looks like that error is gone now! @pdw207

pdw207 commented 7 years ago

Had to whitelist the domain name. Now it works on staging.