Closed InciteDemocracy closed 7 years ago
@aaghevli @pdw207 @pfarnach - With regards to getting the timezone - do you know if we are going to be using the location coords to calculate that, or is there going to be a property in the event object with that? (sorry, I've been out of the loop on Slack for the past few days, so perhaps this was already discussed)
Displaying event time zones doesn't seem to be super important. Event times can be displayed in the local time (for where the event is taking) place in v1.
Hey @dorono, all times should be returned in UTC format, making the use of libraries like moment.js possible to convert to the local timezone client side.
Doing it otherwise requires you to send the lat/long to the server, which complicates caching.
@InciteDemocracy - 2 questions: 1) just to confirm - although the mockup shows "6:00 -9:00 PM EST", we can leave off the "EST", right? 2) Are you cool with the fact that we only have a start time coming from the API, so, assuming that we don't have the timezone is the time display, what the user would see in this case would be "6:00 PM". Is this OK?
Eventually we will def want start time + end time Of course start time is the most important time info, so starting with that would be great! Are you sure there is no end time currently included in the API?
@InciteDemocracy OK, we now have the end time thanks to @aaghevli. :) Arash is still working on getting us the timezone data we'll need in order to convert the time to the local timezone of the event, but in the meantime, I had 2 more questions for you, @InciteDemocracy
There are a fair number of multi day events...
The simplest fix is to drop the day of the week and the time, and only display the start and end dates:
A step up from there would be to include the start time on the first day and the end time on the last day like this:
Hey all, dates are now in the returned endpoint. Will be available on next FB ETL run. Thanks!
@InciteDemocracy - should be doable for the multi-day events, will work on it in the next couple of days.
@dorono I'm assuming we are off by one day due to timezone.
@pdw207 - Yes, I've got it working locally, just have been away from the project due to my being sidelined with strep. The only thing I have left to do is update the functionality for multi-day events.
Will try to work on this today, as I'm starting to feel normal again.
@InciteDemocracy - Removed the timezone display requirement from this ticket and broke it off into https://github.com/ResistanceCalendar/resistance-calendar-frontend/issues/129, since it's a decent amount of effort, and as we discussed, not 100% essential for MVP.
Replace dummy dates and timezone placeholders with the real deal :)