search

ResistanceCalendar / resistance-calendar-frontend

A central listing of upcoming progressive events
https://resistance-calendar-staging.herokuapp.com/
MIT License
7 stars 8 forks source link

implementing docker #212

Open albjeremias opened 6 years ago

albjeremias commented 6 years ago

I trying to setup a docker image of this project.. but i get this error.. any1 can help? :smile_cat: 

Attaching to resistance-calendar-frontend_web_1
web_1  | yarn run v0.24.4
web_1  | $ rimraf dist && webpack -p 
web_1  | module.js:471
web_1  |     throw err;
web_1  |     ^
web_1  | 
web_1  | Error: Cannot find module './webpack/parts'
web_1  |     at Function.Module._resolveFilename (module.js:469:15)
web_1  |     at Function.Module._load (module.js:417:25)
web_1  |     at Module.require (module.js:497:17)
web_1  |     at require (internal/module.js:20:19)
web_1  |     at Object.<anonymous> (/app/webpack.config.js:5:15)
web_1  |     at Module._compile (module.js:570:32)
web_1  |     at Object.Module._extensions..js (module.js:579:10)
web_1  |     at Module.load (module.js:487:32)
web_1  |     at tryModuleLoad (module.js:446:12)
web_1  |     at Function.Module._load (module.js:438:3)
web_1  | error Command failed with exit code 1.
web_1  | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
resistance-calendar-frontend_web_1 exited with code 1
dorono commented 6 years ago

Hey there @albjeremias - without digging into the error - any reason for the deploy to Docker?

Otherwise, maybe it's an issue with the version of Node you're running?

albjeremias commented 6 years ago

im using node:6.10

https://github.com/ResistanceCalendar/resistance-calendar-frontend/pull/212/files#diff-3254677a7917c6c01f55212f86c57fbfR1

dorono commented 6 years ago

Hmm, I don't have experience setting up Docker, but the I was getting an error w/node-sass when trying to run. I got the application to work by:

Not sure if this would have any impact on what you're doing?

Also, awesome that you're contributing - Docker would be awesome - thanks! But I am wondering if there are perhaps some other more pressing issues you would want to work on? Namely https://github.com/ResistanceCalendar/resistance-calendar-frontend/issues/177 is a big sticking point in my opinion, as it would be awesome to use some sort of solution like prerender.io.

However, maybe this has become a necessary task, not sure, but just wanted to throw out the possibility of tackling something that might more directly impact the user experience.

albjeremias commented 6 years ago

I need docker first.. so i can have an environment for development! ;)

dorono commented 6 years ago

@albjeremias - I don't believe you need a docker environment to develop the front end code here, as it's just a React app that runs on Node - or am I missing something?

albjeremias commented 6 years ago

yes... i dont want to install 10 different nodes/react frameworks on my localmachine having conflicts with each other... did you ever used docker anyway?