updated layout as per new mobile design, still need to get social sharing popup working

ResistanceCalendar / resistance-calendar-frontend

A central listing of upcoming progressive events

https://resistance-calendar-staging.herokuapp.com/

MIT License

7 stars 8 forks source link

updated layout as per new mobile design, still need to get social sharing popup working #51

Closed dorono closed 7 years ago

dorono commented 7 years ago

OK, layout is done as per the attached screenshot, however...the behavior for the "SHARE" button dropdown at 1-column view is still not done. I think this PR is a move forward in terms of getting the responsive layout down, so if it looks OK I say merge and I can come back to the SHARE button dropdown tomorrow or in a few days. screenshot 2017-03-24 14 40 28

pfarnach commented 7 years ago

Looks great!

Two quick things: 1.) See my inline comment 2.) Did you run this through the linter? I think there's a couple things it will bark at. If we want to change those rules we definitely can but it'd be nice to avoid having linter warnings build up. Currently it's mostly based off of AirBNB's react/a11y style guides right now

dorono commented 7 years ago

Thanks, @pfarnach - Good call about the linting, will keep it running from now on!