ResonantGeoData / RD-OASIS

ResonantGeoData OASIS Deployment
Apache License 2.0
2 stars 1 forks source link

Replace models with Workflow models #12

Closed jjnesbitt closed 2 years ago

jjnesbitt commented 2 years ago

This PR accomplishes the following main things:

banesullivan commented 2 years ago

With some after thought, @AlmightyYakob would you go ahead and move this algorithms app to the top level of the repo per https://docs.djangoproject.com/en/3.2/intro/reusable-apps/#packaging-your-app

I also think we should rename it to django-rgd-workflow with rgd_workflow as the module name

jjnesbitt commented 2 years ago

With some after thought, @AlmightyYakob would you go ahead and move this algorithms app to the top level of the repo per docs.djangoproject.com/en/3.2/intro/reusable-apps/#packaging-your-app

Sure thing

I also think we should rename it to django-rgd-workflow with rgd_workflow as the module name

I'm fine with that, but if we plan on upstreaming this into https://github.com/ResonantGeoData/ResonantGeoData, would the rename cause any issues there? I suppose not, as we'd just be changing where the code itself lived, but just want to be sure.

jjnesbitt commented 2 years ago

With some after thought, @AlmightyYakob would you go ahead and move this algorithms app to the top level of the repo per docs.djangoproject.com/en/3.2/intro/reusable-apps/#packaging-your-app

I also think we should rename it to django-rgd-workflow with rgd_workflow as the module name

Also, is the core app still needed? And if so, how should that and the algorithms app be coordinated?

banesullivan commented 2 years ago

would the rename cause any issues there? I suppose not, as we'd just be changing where the code itself lived, but just want to be sure.

I don't think there would be any issues from the rename. It would be consistent in the fact that this is another Django app built on top of django-rgd core

Also, is the core app still needed? And if so, how should that and the algorithms app be coordinated?

Yes, the core app is still needed for project-specific migrations and management commands and should remain in the Django Project directory. What do you mean by coordination? the algorithms/workflow app is completely independent of core and at this time, core doesn't have anything linking to algorithms

jjnesbitt commented 2 years ago

I don't think there would be any issues from the rename. It would be consistent in the fact that this is another Django app built on top of django-rgd core

:+1:

Yes, the core app is still needed for project-specific migrations and management commands and should remain in the Django Project directory. What do you mean by coordination? the algorithms/workflow app is completely independent of core and at this time, core doesn't have anything linking to algorithms

I essentially wanted to make sure of this. I'll go ahead with the reorg and rename.