Closed jjnesbitt closed 2 years ago
With some after thought, @AlmightyYakob would you go ahead and move this algorithms app to the top level of the repo per https://docs.djangoproject.com/en/3.2/intro/reusable-apps/#packaging-your-app
I also think we should rename it to django-rgd-workflow
with rgd_workflow
as the module name
With some after thought, @AlmightyYakob would you go ahead and move this algorithms app to the top level of the repo per docs.djangoproject.com/en/3.2/intro/reusable-apps/#packaging-your-app
Sure thing
I also think we should rename it to
django-rgd-workflow
withrgd_workflow
as the module name
I'm fine with that, but if we plan on upstreaming this into https://github.com/ResonantGeoData/ResonantGeoData, would the rename cause any issues there? I suppose not, as we'd just be changing where the code itself lived, but just want to be sure.
With some after thought, @AlmightyYakob would you go ahead and move this algorithms app to the top level of the repo per docs.djangoproject.com/en/3.2/intro/reusable-apps/#packaging-your-app
I also think we should rename it to
django-rgd-workflow
withrgd_workflow
as the module name
Also, is the core
app still needed? And if so, how should that and the algorithms
app be coordinated?
would the rename cause any issues there? I suppose not, as we'd just be changing where the code itself lived, but just want to be sure.
I don't think there would be any issues from the rename. It would be consistent in the fact that this is another Django app built on top of django-rgd
core
Also, is the
core
app still needed? And if so, how should that and thealgorithms
app be coordinated?
Yes, the core
app is still needed for project-specific migrations and management commands and should remain in the Django Project directory. What do you mean by coordination? the algorithms/workflow app is completely independent of core
and at this time, core
doesn't have anything linking to algorithms
I don't think there would be any issues from the rename. It would be consistent in the fact that this is another Django app built on top of
django-rgd
core
:+1:
Yes, the
core
app is still needed for project-specific migrations and management commands and should remain in the Django Project directory. What do you mean by coordination? the algorithms/workflow app is completely independent ofcore
and at this time,core
doesn't have anything linking toalgorithms
I essentially wanted to make sure of this. I'll go ahead with the reorg and rename.
This PR accomplishes the following main things: