ResonantGeoData / RD-OASIS

ResonantGeoData OASIS Deployment
Apache License 2.0
2 stars 1 forks source link

Pin `django-composed-configuration` to the latest version in setup.py #48

Closed mvandenburgh closed 2 years ago

mvandenburgh commented 2 years ago

This will resolve the CI failures seen in downstream projects such as https://github.com/girder/Danesfield/pull/37

mvandenburgh commented 2 years ago

Hmm check-migrations is still failing.... :thinking:

Need to look into this further

banesullivan commented 2 years ago

It's because these migrations are for django4 and the test environment is limited to Django3 installing Django==3.2.12

See https://github.com/ResonantGeoData/RD-OASIS/blob/11eaa4425ae1580f3319b00e921b5444cda6443a/setup.py#L40

(I think)

banesullivan commented 2 years ago

@mvandenburgh, since you're now pinning the RGD dependencies, let's add the following Dependabot workflow for RGD in .github/workflows/dependabot.yml:

name: RGD Dependabot
on:
  workflow_dispatch:
  schedule:
    - cron: "0 0 * * *"
jobs:
  check-rgd:
    runs-on: ubuntu-latest
    steps:
      - uses: marcoroth/dependabot-bump-together-action@main
        with:
          dependencies: django-rgd, django-rgd-3d, django-rgd-fmv, django-rgd-geometry, django-rgd-imagery
          package_managers: pip
          directory: /
          branch: main
          username: x-access-token
          token: ${{ secrets.GITHUB_TOKEN }}

This action will update all the RGD apps at once in a single PR

banesullivan commented 2 years ago

FYI, if upgrading to RGD v3, you MUST add django_large_image to the installed_apps

mvandenburgh commented 2 years ago

@mvandenburgh, since you're now pinning the RGD dependencies, let's add the following Dependabot workflow for RGD in .github/workflows/dependabot.yml:

This action will update all the RGD apps at once in a single PR

It looks like that action is already present in main and has been running consistently, but keeps erroring https://github.com/ResonantGeoData/RD-OASIS/runs/5878108153?check_suite_focus=true. Maybe this PR will fix it, seems like some more issues with pip package resolving