ResoniteModdingGroup / MonkeyLoader.GamePacks.Resonite

MonkeyLoader Game Pack which provides hooks for Resonite mods.
https://resonitemoddinggroup.github.io/MonkeyLoader.GamePacks.Resonite/
GNU Lesser General Public License v3.0
14 stars 2 forks source link

Possibly make the injected colorX template non-persistent so it doesn't get saved with the dash #25

Closed Nytra closed 3 months ago

Nytra commented 4 months ago

The way it works right now it could get saved with the dash, then used anywhere else where a colorX item is needed in the settings, even in other categories.

It's not a problem right now since there are no colorX items elsewhere, but could be a problem in the future if the Resonite team adds colorX settings.

Banane9 commented 4 months ago

Oh damn, I thought you made it non persistent... Do the templates even get saved? Thought it all gets reconstructed when loaded 🤔

Nytra commented 4 months ago

I think the templates might get saved. Not sure how it works exactly.

Nytra commented 3 months ago

~I'm not sure exactly how to approach this one because it's not enough to just make the slot non-persistent, we actually need to remove the mapping from the DataFeedItemMapper too :/~

Actually I think if the mapping template is null the entry is ignored

Banane9 commented 3 months ago

Looked at a few logs and it always says that the template got injected, so I don't think this is an issue 👀

Nytra commented 3 months ago

Well you need to trigger a dash save by either adding a facet or marking changes on the Workspace component, but I have verified that our injected template does get saved if you do that.

Banane9 commented 3 months ago

Ahhhhh, I see... that's annoying. Could add code to clean it up too, I guess?