search

ResoniteModdingGroup / MonkeyLoader.GamePacks.ResoniteModLoader

MonkeyLoader Game Pack that provides compatibility for ResoniteModLoader.
GNU Lesser General Public License v3.0
5 stars 2 forks source link

RML mods are seemingly being added twice #18

Closed Nytra closed 1 month ago

Nytra commented 1 month ago

This line Mod.Loader.AddMod(rmlMod); is in the LoadMods method, but then it is being executed again in InitializeFrooxEnginePostfixAsync after the LoadMods call.

https://github.com/ResoniteModdingGroup/MonkeyLoader.GamePacks.ResoniteModLoader/blob/7c692a32e434b01c4368c84698aa0de1a72c0247/MonkeyLoader.GamePacks.ResoniteModLoader/ModLoader.cs#L116

Banane9 commented 1 month ago

It's not really a problem because it uses a Set internally, but should be removed, yea lol. You can remove the one you linked to in the Initialize method.

Banane9 commented 1 month ago

Can also move the ExitSubphase thing in the LoadMods method into a finally while you're at it :'D