search

Respect / Config

A powerful, small, deadly simple configurator and dependency injection container DSL made to be easy
http://respect.github.io/Config
Other
98 stars 7 forks source link

Changing regex for evaluation of a constant #56

Closed diegocpires closed 9 years ago

diegocpires commented 9 years ago

This change added the option to use a constant from any namespace.

The issue #39 is resolved by this PR.

henriquemoody commented 9 years ago

Thanks @diegocpires!

Can you provide us some tests to this change?

diegocpires commented 9 years ago

Sure @henriquemoody .

I need cancel this PR and create another, after tests?

henriquemoody commented 9 years ago

No, just push your commits to your branch and this PT is gonna be updated automatically.

diegocpires commented 9 years ago

I dont understand.

My tests with phpunit are ok. But, in travis, the function class_alias used in test, not worked. But, the function class_alias is PHP 5 >= 5.3.0

diegocpires commented 9 years ago

Looking changelog, i guess the class_alias in PHP 5.3 not accept a class with leading backslashes.

diegocpires commented 9 years ago

Sorry a lot of commits :-1:

henriquemoody commented 9 years ago

Thanks for the tests. Yes, it's a lot of commits, do you mind to squash these commits into once?

diegocpires commented 9 years ago

OMFG... I do a wrong rebase! My bad.

henriquemoody commented 9 years ago

I'm not sure if you know that, but there are a couple rules about rebasing, specially after the rebase:

  1. Never perform git pull (or merge remote changes)
  2. You must force the push (git push -f your_remote your_branch)

When you're rebasing, you change all references between the local branch and the remote one, so, it's impossible to perform just a git push your_remote your_branch, you must force it. That's why you must be pretty aware about what you're doing and what is in the remote branch.

Tell me if you need ant help.

diegocpires commented 9 years ago

Thanks @henriquemoody. Now i believe it is ok!

henriquemoody commented 9 years ago

@diegocpires, it's perfect.

Thanks for contributing.

henriquemoody commented 9 years ago

BTW, this change is now available on 1.1.0 version.

henriquemoody commented 9 years ago

I'm sorry, there was API changes on master, the version with this change is 2.0.0.