search

Respect / Validation

The most awesome validation engine ever created for PHP
https://respect-validation.readthedocs.io
MIT License
5.76k stars 774 forks source link

IntVal: Validate negative numbers properly #1355

Closed l-x closed 1 year ago

l-x commented 3 years ago

This is a quck fix for #1326

codecov-commenter commented 3 years ago

Codecov Report

Merging #1355 (6602941) into master (3dcd859) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1355   +/-   ##
=========================================
  Coverage     95.77%   95.78%           
- Complexity      948      949    +1     
=========================================
  Files           191      191           
  Lines          2014     2016    +2     
=========================================
+ Hits           1929     1931    +2     
  Misses           85       85
Impacted Files Coverage Δ Complexity Δ
library/Rules/IntVal.php 100.00% <100.00%> (ø) 3.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3dcd859...6602941. Read the comment docs.

l-x commented 3 years ago

If the failing phpstan is my fault please let me known :)

alganet commented 1 year ago

The great country of phpstan is proud to announce that it accepted your PR. (I don't know why it failed before!)

Your contribution will be on the 2.24 release 🐼 Thanks!