search

Respect / Validation

The most awesome validation engine ever created for PHP
https://respect-validation.readthedocs.io
MIT License
5.76k stars 774 forks source link

Validate Iban #1367

Closed micgay closed 1 year ago

micgay commented 2 years ago

the function bcmod($this->convertToInteger($rearranged), '97') return '1.00' with PHP 7.4 so bcmod($this->convertToInteger($rearranged), '97') === '1' return false and bcmod($this->convertToInteger($rearranged), '97') == '1'; return true Please could you fix the issue ?

alganet commented 1 year ago

I noticed that you're taking about the implementation of Rules\Iban, which I believe has changed since this was opened. It now reads bcmod($this->convertToIntegerAsString($rearranged), '97').

I can't be sure which IBANs were failing for you. If this is still a problem, can you reopen it with some examples of failed IBANs?

Thanks!