search

Respect / Validation

The most awesome validation engine ever created for PHP
https://respect-validation.readthedocs.io
MIT License
5.76k stars 774 forks source link

ctype_digit deprecation notice #1393

Closed Tsaukpaetra closed 1 year ago

Tsaukpaetra commented 1 year ago

https://github.com/Respect/Validation/blob/3dcd859d986f1b586b5539ea19962723ab7352ed/library/Rules/IntVal.php#L39

Getting a warning in PHP 8 that null types will be coerced into strings.

Should there be a null guard around this, or should I actually be pre-guarding it with a Not Null rule higher in the chain?

Tsaukpaetra commented 1 year ago

Eek, I have sinned. This is a duplicate of #1391