Respect / Validation

The most awesome validation engine ever created for PHP
https://respect-validation.readthedocs.io
MIT License
5.75k stars 774 forks source link

Update a few exception messages #1417

Closed henriquemoody closed 1 year ago

alganet commented 1 year ago

These tests failing are weird:

1) Respect\Validation\Rules\DateTimeTest::shouldValidateNoMatterTimezone with data set #6 ('Ym', '202302', 'Europe/Amsterdam')
Failed asserting that false is true.

/home/runner/work/Validation/Validation/tests/unit/Rules/DateTimeTest.php:124

2) Respect\Validation\Rules\DateTimeTest::shouldValidateNoMatterTimezone with data set #7 ('Ym', '202302', 'UTC')
Failed asserting that false is true.

/home/runner/work/Validation/Validation/tests/unit/Rules/DateTimeTest.php:124

3) Respect\Validation\Rules\DateTimeTest::shouldValidateValidInput with data set #16 (Respect\Validation\Rules\DateTime Object (...), 202302)
Validation with input 202302 is expected to pass
Failed asserting that false is true.

It could be flakyness hapenning on last day of a month (I've seen other codebases experiencing similar issues).

@henriquemoody Are you OK with waiting for one day to see if these tests will pass tomorrow? If we wait one day, and they pass, we should create an issue about this last-day-of-month stuff.