search

Respect / Validation

The most awesome validation engine ever created for PHP
https://respect-validation.readthedocs.io
MIT License
5.75k stars 774 forks source link

Rename "Attribute" rule to "Property" #1418

Closed henriquemoody closed 5 months ago

henriquemoody commented 1 year ago

Because now we have the concept of attributes in PHP, the rule with the name "Attribute" makes no sense because it doesn't validate attributes but properties.

In the future, it might be possible that Validation will have a rule called "Attribute" to validate PHP attributes.

alganet commented 1 year ago

Again, I wasnt't expecting more contributors :D (see https://github.com/Respect/Validation/pull/1424#issuecomment-1590259062).

I agree with this change and I'm willing to move it forward, we just need to figure out how we deal with the branches to keep 2.3 without this BC break, and introduce it later (2.4 or something else).

henriquemoody commented 1 year ago

I'm not in a rush to get any of my changes merged. I was writing some code just because, as a manager, I sometimes miss coding :D

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (715bf4b) 94.91% compared to head (250fd93) 94.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1418 +/- ## ========================================= Coverage 94.91% 94.91% Complexity 981 981 ========================================= Files 195 195 Lines 2223 2223 ========================================= Hits 2110 2110 Misses 113 113 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.