search

Respect / Validation

The most awesome validation engine ever created for PHP
https://respect-validation.readthedocs.io
MIT License
5.79k stars 776 forks source link

Improve tests #1420

Closed henriquemoody closed 1 year ago

henriquemoody commented 1 year ago

@alganet, There's still some work to do here, but I figured that upgrading to PHPUnit 10 would mean that we would need to drop support for PHP 8.0. I would say that we should go for it, at the moment there are only security fixes for version 8.0. Any thoughts?

alganet commented 1 year ago

@henriquemoody

2.2.4 dropped PHP 7.3, but it still supports 7.4. Jumping straight to 8.1 seems too big of a jump here. Our users might also be stuck in older versions, and we need to give them a fighting chance.

I wanted to make 2.3 the final 2.x release, but I'm willing to do a 2.4 just for the PHP 8.0 deprecation if that's the case. I feel that would strike a good balance between moving to newer dependencies fast and leaving a good breathing room for users who are following the upgrade path.

I like the changes, the stream stubs are sweet!

henriquemoody commented 1 year ago

That makes sense, @alganet!

I don't think there's any changes that required PHP 8.1 besides upgrading respect/coding-standards and phpunit/phpunit.

I will update a few commit messages, remove the commits with the package upgrades, and will let you know when the changes are good for review!