search

Respect / Validation

The most awesome validation engine ever created for PHP
https://respect-validation.readthedocs.io
MIT License
5.75k stars 774 forks source link

Increase test coverage of the following Rules #1457

Closed dcorrea777 closed 2 months ago

dcorrea777 commented 2 months ago
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.41%. Comparing base (2ae1df1) to head (5084aae).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1457 +/- ## ============================================ + Coverage 96.23% 97.41% +1.17% Complexity 923 923 ============================================ Files 199 199 Lines 2125 2125 ============================================ + Hits 2045 2070 +25 + Misses 80 55 -25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dcorrea777 commented 2 months ago

I was actually a bit unsure whether it was really necessary to call the evaluate method, but now it's clear to me. Thank for you reply @henriquemoody

henriquemoody commented 2 months ago

The only thing I would change in your merge request is the commit message. The short message says, "Increase test coverage of the following Rules," but when you see that in the commit list, that doesn't make much sense because the following rules are not in the short message. In this case, I would just say, "Increase code coverage for some rules"

henriquemoody commented 2 months ago

Merged by 719f12a424b34c171b1afee4e576e1da6aadae82

Thank you for contributing, @dcorrea777!! 🐼