search

RespiraWorks / Ventilator

Fully-featured ICU ventilator design, optimized for manufacture using commonly available components and free to license. Repository tracks all mechanical, electrical and systems design, software, requirements and regulatory documentation.
Apache License 2.0
130 stars 38 forks source link

Ensure config data is within hard limits #83

Closed martukas closed 4 years ago

martukas commented 4 years ago

Subtask of #58 Needs further explanation. How are these limits defined? Can we link to a specs document? And most importantly, is this critical for Alpha? @lee-matthews @neelfirst

neelfirst commented 4 years ago

It looks like #58 is beta so this should be beta as well. I'm not really sure what this means anyways.

lee-matthews commented 4 years ago

These are to validation check input values to be sure that they're within safe limits. It's to stop someone inadvertently setting the respiration rate to 1000 breaths/minute for example.

On Tue, 14 Apr 2020, 19:17 neelfirst, notifications@github.com wrote:

It looks like #58 https://github.com/RespiraWorks/VentilatorSoftware/issues/58 is beta so this should be beta as well. I'm not really sure what this means anyways.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RespiraWorks/VentilatorSoftware/issues/83#issuecomment-613570261, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEXLVLGUT7S4IMPXFWY5BG3RMSLDPANCNFSM4MHQN4JA .

tapemaster commented 4 years ago

Implemented by having limits on GUI input widgets.