ResponsiveBP / Responsive

:iphone: A super lightweight HTML, Sass, CSS, and JavaScript framework for building responsive websites
http://responsivebp.com
MIT License
868 stars 134 forks source link

modal-group + mobile-target inconsistent in Google Chrome #113

Open fotografitti opened 5 years ago

fotografitti commented 5 years ago

In Google Chrome: If I add data-modal-mobile-target="..." to grouped images, with the first call, (on a mobile device) it opens the lightbox. Then pressing the arrow, it shows the mobile target (so just the picture). In Firefox it works as expected ans opens just the image and then one has to go back.

Also in Chrome I get a warning in the console: [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. I think its related, but my javascript knowledge is limited and I was not successful fixing it...

JimBobSquarePants commented 5 years ago

Hi @fotografitti

Apologies for the slow reply.

In Google Chrome: If I add data-modal-mobile-target="..." to grouped images, with the first call, (on a mobile device) it opens the lightbox. Then pressing the arrow, it shows the mobile target (so just the picture). In Firefox it works as expected ans opens just the image and then one has to go back.

I'm not sure I understand. Are you testing this on a desktop browser?

Also in Chrome I get a warning in the console: [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. I think its related, but my javascript knowledge is limited and I was not successful fixing it...

I'm currently working on v5 and will look at this as part of that release.

JimBobSquarePants commented 5 years ago

https://github.com/WICG/EventListenerOptions/blob/gh-pages/explainer.md