ResponsiveBP / Responsive

:iphone: A super lightweight HTML, Sass, CSS, and JavaScript framework for building responsive websites
http://responsivebp.com
MIT License
868 stars 134 forks source link

Modal focus management issues #56

Closed cvrebert closed 9 years ago

cvrebert commented 9 years ago
JimBobSquarePants commented 9 years ago

Thanks for that. In my tests the modal is focused on show. However you are right that the trigger should be focused on hide.

https://github.com/ResponsiveBP/Responsive/blob/v4/src/js/responsive.modal.js#L135

cvrebert commented 9 years ago

I beg to differ regarding show. Screencast on Mac Chrome: modal Note the blue focus ring on the link.

JimBobSquarePants commented 9 years ago

No worries, thanks . Feel free to submit a pull request if you spot what is wrong.

cvrebert commented 9 years ago

Not interested in investigating the cause... Anyway, happy hunting!