search

ResponsiveImagesCG / demos

Demos and tests to show off how picture works.
16 stars 11 forks source link

Demos should "just work" #6

Closed marcoscaceres closed 11 years ago

marcoscaceres commented 12 years ago

When we have time, we should make sure demos are polyfilled (if they are not already).

@Wilto has a picture compatible version of picturefill we can use already, I think.

anselmh commented 12 years ago

+1 Though not sure if Wilto's polyfill does work the exactly way the spec now says.

attiks commented 12 years ago

I've worked on @Wilto picture version: http://picturefill8.h011.attiks.com/core/modules/picture/picturefill/picturefill.js?v=0.1 feel free to use it.

marcoscaceres commented 12 years ago

@attiks thanks! @anselmh how should we handle this? Are you ok to add the polyfill or should we split up the task?

anselmh commented 12 years ago

I am still thinking if that is the right way to go.

Decision between: 1) We should split real demos from polyfill demos > you get the real deal 2) only one demo which works for everyone > you don't get the real deal but a working demo

What do you think @marcoscaceres?

nwtn commented 12 years ago

3) one demo that detects for support, and uses polyfill if it's not present?

marcoscaceres commented 12 years ago

yeah, I was thinking 3 as well :)

anselmh commented 12 years ago

Okay, thanks. So if anybody has time, feel free to add a pull-req. I can merge. Else it'll take some more days but I'll try my best.

marcoscaceres commented 12 years ago

Detecting support should be something like:

if(!("HTMLPictureElement" in window)){ //load polyfill }

I'll try to do this tomorrow and test it out.

marcoscaceres commented 12 years ago

Started work.

marcoscaceres commented 12 years ago

Made a new branch called polyfilled.

marcoscaceres commented 12 years ago

Ok, I think I'm done. @Wilto will review the demos on the weekend. @anselmh, feel free to also QA (make sure you grab the polyfilled branch). Once we have an ok, will push up to the server.

marcoscaceres commented 12 years ago

Oh, two things that still need to be checked/fixed:

  1. have not tested the updated templates in the Chromium build
  2. Android and iOS (iphone) still has some issues because of the source being showed (it won't fix, so keeps screwing up the layout)
marcoscaceres commented 11 years ago

Moved to gh-pages. We can files issues on separate bugs.

marcoscaceres commented 11 years ago

by gh-pages, I mean http://demos.responsiveimages.org has been updated :)