search

ResponsiveImagesCG / meta

Repository for media, tools, etc.
7 stars 3 forks source link

Create a demo of <picture> #7

Closed marcoscaceres closed 11 years ago

marcoscaceres commented 11 years ago

It would be nice to present running in Webkit at the W3C TPAC meeting.

Wilto commented 11 years ago

Native, you mean? I can whip up an example page using the markup and polyfill, if need be.

marcoscaceres commented 11 years ago

@Wilto that would be great. And yep, native.

yoavweiss commented 11 years ago

I'm working on the native part. Hopefully, I'd have more to show in a week. I have an extremely basic demo page at http://yoavweiss.github.com/RespImg-WebCore/ but something fancier would be nice.

yoavweiss commented 11 years ago

Got <picture><source src></picture> working! Next step is getting MQs to work like they should (both in PreloadScanner and in choosing the right source to display)

yoavweiss commented 11 years ago

Binaries are at https://github.com/yoavweiss/RespImg-WebCore/downloads

marcoscaceres commented 11 years ago

Awesomeness! trying it out!

attiks commented 11 years ago

I tried as well, but I get ./chrome_release: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.14' not found (required by ./chrome_release) ./chrome_release: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: versionGLIBCXX_3.4.15' not found (required by ./chrome_release)

anselmh commented 11 years ago

This Chromium build does not work for me. I tested it with the following test-page (which is build after the draft from 17th Oct 12): http://tests.anselm-hannemann.com/w3c.respimg/chromium/

It seems that this does not recognize media-queries.

marcoscaceres commented 11 years ago

@anselmh yes, media queries are not supported yet. Baby steps :)

yoavweiss commented 11 years ago

@attiks - uploaded a release version (rather than a stripped debug version). Can you try it?

attiks commented 11 years ago

Nope, but don't waste to much time on this, might be my machine

./chrome: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.14' not found (required by ./chrome) ./chrome: /lib/x86_64-linux-gnu/libc.so.6: versionGLIBC_2.15' not found (required by ./chrome) ./chrome: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.15' not found (required by ./chrome)

nwtn commented 11 years ago

@yoavweiss Awesome job, the OS X version is working beautifully for me. It does, however, load src from both and . Is this by design? (I think I saw this came up on IRC, but I either forget or missed the end result.)

marcoscaceres commented 11 years ago

@nwtn we are still not sure on that one. There are advantages and disadvantages.

yoavweiss commented 11 years ago

@nwtn IMO, the way it's currently implemented (i.e. download src attr even though source is the one displayed) is a bug. (see https://github.com/yoavweiss/RespImg-WebCore/issues/1). What @marcoscaceres was referring to is that there may be cases where we want the src attr to be displayed (for example, if there are no matching source tags). Anyway, I plan to fix it for now, and maybe implement src attr fetching only in the cases it is necessary later.

marcoscaceres commented 11 years ago

@yoavweiss IMO, it should work exactly the same as audio and video.

yoavweiss commented 11 years ago

@marcoscaceres no objections here, but let's take this issue to the spec's repo - https://github.com/ResponsiveImagesCG/picture-element/issues/2

yoavweiss commented 11 years ago

<picture src> issues are fixed in: https://github.com/yoavweiss/RespImg-WebCore/commit/91aa93dd4ca2d10efa8146f50a56e32a3c9b9b0f

marcoscaceres commented 11 years ago

@yoavweiss Chromium build worked perfectly during TPAC :) Again awesome work!

I'm preparing the video now and will record a video showing how it works based on the presentation we gave at tpac. See issue 11