search

ResponsiveImagesCG / picture-element

This is the <picture> element specification.
http://picture.responsiveimages.org
Other
187 stars 35 forks source link

Ban functions in sizes other than calc() #241

Closed zcorpan closed 10 years ago

zcorpan commented 10 years ago

It's not super clear what toggle() and attr() should do in sizes="". We should just ban anything but calc().

tabatkins commented 10 years ago

toggle() technically works, but since there's no inherited value, it'll just always select its first value. Fine to ban it.

attr() is technically only defined within the context of a property, which sizes isn't, so it doesn't actually work. Fine to ban it too.

I agree that it should be fine to just whitelist calc(), and we can expand the list in the future if needed.