search

ResponsiveImagesCG / responsiveimages.org

Landing page for our specs, info, demos, etc.
34 stars 20 forks source link

Switched to using CDN version of picturefill (closes #70) #71

Closed marcoscaceres closed 9 years ago

marcoscaceres commented 9 years ago

@seriema can you please check? Or any other lovely person:)

seriema commented 9 years ago

@marcoscaceres I cloned it locally and checked all the demos. Seems fine, no errors that I could se. :+1:

As a sidenote, I do get some things that don't load properly (like CSS on some pages) or some links not working because there seems to be a mix of how links are written. With / or without, causing it to go to root sometimes and sometimes not. Want me to clean that up? =)

marcoscaceres commented 9 years ago

Want me to clean that up? =)

Sure! that would be great!

coliff commented 9 years ago

Would be good to update again to Picturefill 2.3.1. :-) http://scottjehl.github.io/picturefill/#download

marcoscaceres commented 9 years ago

@coliff, done.

seriema commented 9 years ago

Maybe we can get cdnjs or Picturefill to add a "latest" link (like @marcoscaceres seemed to want in #70 )? So we don't have to keep manually add these requests here. I'm falling behind on my open-source-promises atm so if anyone would like to check what we would need to do to make it happen, feel free to do it.

marcoscaceres commented 9 years ago

Would be great. I don't know the folks that run the CDN... @Wilto maybe?

Wilto commented 9 years ago

Your guess is as good as mine, honestly. We could file an issue over at https://github.com/cdnjs/cdnjs

marcoscaceres commented 9 years ago

@Wilto, nice! thanks for the link.

coliff commented 9 years ago

@Wilto @marcoscaceres I saw this requested already... https://github.com/cdnjs/cdnjs/issues/360

marcoscaceres commented 9 years ago

Ok, cool... not great that it's not possible... but at least it's on the radar and a known issue.