What's our goal here? - Githubissues

ResponsiveImagesCG / wp-respimg

Responsive images for Wordpress.

6 stars 1 forks source link

What's our goal here? #2

Closed tevko closed 8 years ago

tevko commented 10 years ago

I'm really excited to get get started, but beforehand, I have a few questions. I'll start with the two most important ones:

Do we plan to include picturefill?
Do we aim to target the whole spec, or just a specific section (sizes or picture element)

Wilto commented 10 years ago

Yo, sorry for the delay; been wrapping up a big project the past couple weeks, but I’m back in respimg land now.

I’d really like to have Picturefill in there, though not necessarily as a forever-dependency or anything. No way of knowing how long we’ll need to polyfill this biz exactly, but users are gonna see a ton of benefit right away if we do.
The whole spec is the plan, grand scheme. I really want to nail the srcset/sizes stuff first (a la http://css-tricks.com/responsive-images-youre-just-changing-resolutions-use-srcset ) first though, I think.

tevko commented 10 years ago

Cool, makes sense. I agree with the srcset/sizes implementation first, as it feels very 'default option-y'.

Wilto commented 10 years ago

Yeah, I figure that part can really happen invisibly. Server churns out a couple of smaller versions and the markup, no real interaction required from the uploaders—“on by default” responsive images.

tevko commented 10 years ago

Been working on this for the better part of the day, very close to having something to show for it. Should I make a pull request when finished?

Wilto commented 10 years ago

Oh absolutely. You’re doing this in plugin form, yeah?

Wilto commented 10 years ago

I’m not super up on the best way to work on a WP plugin, so I just forked WP itself over to https://github.com/ResponsiveImagesCG/WordPress — or we just use this current repo for the plugin itself. I defer to you on this one.

tevko commented 10 years ago

I have two versions being worked on, plugin form and native. This would be for native, in which most of the edits take place in \wp-includes\media.php. I'll get native done and commit to https://github.com/ResponsiveImagesCG/WordPress, and then I'll add the plugin to this repo

tevko commented 10 years ago

Pull request created! It's proof of concept code, just a warning

Wilto commented 10 years ago

Awesome. I’m on the road right now, but I’ll be able to dig into this next week.

tevko commented 8 years ago

closing this as im p sure the goal has been accomplished

joemcgill commented 8 years ago

the goal has been accomplished

:tada: