Further streamlining changes

ResponsiveImagesCG / wp-tevko-responsive-images

Fully responsive image plugin for wordpress

449 stars 53 forks source link

Further streamlining changes #198

Closed peterwilsoncc closed 9 years ago

peterwilsoncc commented 9 years ago

This is for merging into the branch 187-streamlining.

f2dc120405b355ad24be2357f61974b8ee4ceb1a - reduces regular expressions in tevkori_filter_content_images, replacing preg_replace_callback with str_replace
69ad5dd02658052528b12fee3952ac96fedd0c30 - warm cache properly (see gh-197), doesn't reduce DB calls from WP_Query.

peterwilsoncc commented 9 years ago

Added cbf7dcb7ac06158fc1b7ebe163df6bc9bc2bb9dc Wraps a filter around the regular expression pattern for gh-190, I named it tevkori_search_images_pattern but I am certain there is something better.

joemcgill commented 9 years ago

Interestingly, it looks like update_postmeta_cache() doens't give us the same benefit that we were getting before, which makes me think that we're benefiting from the whole post object being cached.

There seems to be some performance boost by removing the second preg_match call in f2dc120, but it seems very slight in the examples I've tested.

peterwilsoncc commented 9 years ago

I'll check out the other cache priming functions, maybe _prime_post_caches( $ids, false, true );

joemcgill commented 9 years ago

Related: #187

joemcgill commented 9 years ago

Thanks @peterwilsoncc. I've merged most of these changes in #200. Let's do cbf7dcb in a separate pull request. I want to make sure we've let the placement of this filter simmer for a bit so we don't end up introducing back-compat issues.